Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40765 )
Change subject: Makefile: Add is-power-of-two
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40765/1/Makefile.inc
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/40765/1/Makefile.inc@162
PS1, Line 162: 0x10000000 0x20000000 0x40000000 0x80000000
(Actually I think __builtin_choose_expr() might not help there either, but we could still define an […]
It seems like a _Static_assert would work. Power of 2 check is just ((x) & ((x) - 1)) == 0. Raul, can't we do that ?
https://review.coreboot.org/c/coreboot/+/40765/4/Makefile.inc
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/40765/4/Makefile.inc@588
PS4, Line 588: APCB_EDIT_TOOL:=$(top)/util/apcb/apcb_edit.py
This is unrelated?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40765
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I189a4c722996279e2d8940c566cb362f53ef92d8
Gerrit-Change-Number: 40765
Gerrit-PatchSet: 4
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 07 May 2020 05:24:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment
