[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Configure THC

[Wonkyu Kim (Code Review)]

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41571 )

Change subject: soc/intel/tigerlake: Configure THC
......................................................................

Patch Set 4: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/41571/3/src/soc/intel/tigerlake/fsp... 
File src/soc/intel/tigerlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/41571/3/src/soc/intel/tigerlake/fsp... 
PS3, Line 223: 	else
             : 		params->ThcPort1Assignment = dev->enabled;
> shouldn't this be: […]

You're correct. Thanks for catching this.
ThcAssignmentThc0 should be ThcAssignmentThc0(1) and ThcAssignmentThc1 should be ThcAssignmentThc1(2) to be enabled.