[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Add generic SMU service request

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41625 )

Change subject: soc/amd/picasso: Add generic SMU service request
......................................................................

Patch Set 1:

(1 comment)

I'm reworking this patch right now

https://review.coreboot.org/c/coreboot/+/41625/1/src/soc/amd/picasso/smu.c 
File src/soc/amd/picasso/smu.c:

https://review.coreboot.org/c/coreboot/+/41625/1/src/soc/amd/picasso/smu.c@2... 
PS1, Line 29: 		if (!smu_read32(REG_ADDR_MESG_RESP)) {
this is very likely wrong; should probably be if (smu_read32(REG_ADDR_MESG_RESP))