Attention is currently required from: Maximilian Brune, Patrick Georgi, Philipp Hug, ron minnich.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81410?usp=email )
Change subject: arch/riscv: add Kconfig variable RISCV_HAS_MENVCFG ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81410/comment/64a0e568_73c60256 : PS1, Line 10: Provide a Kconfig variable, default y, to enable it. What happens if it's enabled but not present in the chip vs if it's present but disabled? Is this definitely the correct direction for the option?
I assume that the printf is just a placeholder for the code that will actually do something with it which will come later?
File src/arch/riscv/payload.c:
https://review.coreboot.org/c/coreboot/+/81410/comment/f7ffee5b_a7ea961a : PS1, Line 72: part Nit: Chip? SOC?
Change it or not - up to you.