Attention is currently required from: Felix Singer, Raul Rangel, Nico Huber, Furquan Shaikh, Matt DeVillier, Angel Pons, Patrick Rudolph, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52493 )
Change subject: [RFC] soc/intel/skylake: Introduce new method for setting device states ......................................................................
Patch Set 10:
(4 comments)
File src/soc/intel/skylake/fspdevmap.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118122): https://review.coreboot.org/c/coreboot/+/52493/comment/a7c43df4_75a086c1 PS10, Line 8: UINT8 *const option; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118122): https://review.coreboot.org/c/coreboot/+/52493/comment/54abbedb_81209066 PS10, Line 13: void set_dev_state_by_devicetree(const struct device_fspoption_map *devmap, const uint8_t arrsize); line over 96 characters
File src/soc/intel/skylake/fspdevmap.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118122): https://review.coreboot.org/c/coreboot/+/52493/comment/8dd62335_594a5938 PS10, Line 6: void set_dev_state_by_devicetree(const struct device_fspoption_map *devmap, const uint8_t arrsize) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118122): https://review.coreboot.org/c/coreboot/+/52493/comment/6cfd2605_06107560 PS10, Line 13: if (dev) { braces {} are not necessary for single statement blocks