[coreboot-gerrit] Change in coreboot[master]: mediatek/mt8183: Implement the dramc init setting

[Huayang Duan (Code Review)]

Huayang Duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34988 )

Change subject: mediatek/mt8183: Implement the dramc init setting
......................................................................

Patch Set 17:

(5 comments)

https://review.coreboot.org/c/coreboot/+/34988/2/src/soc/mediatek/mt8183/inc... 
File src/soc/mediatek/mt8183/include/soc/dramc_pi_api.h:

https://review.coreboot.org/c/coreboot/+/34988/2/src/soc/mediatek/mt8183/inc... 
PS2, Line 119: 0x2
> By MTK's spec, '0x2' means "Unit: 1x clock", so actually I don't think it's a magic number.

Done

https://review.coreboot.org/c/coreboot/+/34988/2/src/soc/mediatek/mt8183/inc... 
PS2, Line 121: 0x1
> This constant is removed in the next CL (https://review.coreboot.org/c/coreboot/+/34332/29).

Done

https://review.coreboot.org/c/coreboot/+/34988/2/src/soc/mediatek/mt8183/inc... 
PS2, Line 129: 0x3
> Same as above.

Done

https://review.coreboot.org/c/coreboot/+/34988/2/src/soc/mediatek/mt8183/inc... 
PS2, Line 139: 0x4
> Same as above.

Done

https://review.coreboot.org/c/coreboot/+/34988/2/src/soc/mediatek/mt8183/inc... 
PS2, Line 141: 0x3
> Same as above.

Done