[coreboot-gerrit] [S] Change in coreboot[master]: device/mdio: Provide helper functions for read and write

[Arthur Heymans (Code Review)]

Attention is currently required from: Mario Scheithauer, Angel Pons, Werner Zeh.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69611 )

Change subject: device/mdio: Provide helper functions for read and write
......................................................................

Patch Set 5: Code-Review+1

(1 comment)

File src/device/mdio.c:

https://review.coreboot.org/c/coreboot/+/69611/comment/b250d352_720430d3 
PS4, Line 27: 0
> Do you know if the MDIO spec specifies a default value when attempting to read from a non-existing device? It'd be good to use the same value here.
>
> For PCI devices, this value would be all ones.

I'd just add an assert here and keep the same behavior. Then it will show up in the logs that something is wrong.