Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36914 )
Change subject: binaryPI: implement C bootblock
......................................................................
Patch Set 13:
(2 comments)
Kyösti I should credit you for the BSP stack issue on C bootblock (CB:34883). Feel free to add your signoff to the commit, or I can do it if you want.
https://review.coreboot.org/c/coreboot/+/36914/8/src/drivers/amd/agesa/cache...
File src/drivers/amd/agesa/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/36914/8/src/drivers/amd/agesa/cache...
PS8, Line 114: #else
Maybe just use a different file and let the Makefile do its job?
Done
https://review.coreboot.org/c/coreboot/+/36914/8/src/drivers/amd/agesa/cache...
PS8, Line 142: OSFXSR [
I just noticed neither SSE nor SSE2 is selected for any AMD AGESA or binaryPI... […]
After selecting SSE2 in Kconfig, setting the FPU EM bit, OSFXSR and OSXMMEXCPT became obsolete, thus removed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36914
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29916a96f490ff717c69dc7cd565d74a83dbfb0d
Gerrit-Change-Number: 36914
Gerrit-PatchSet: 13
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Mike Banon
mikebdp2@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 Nov 2019 21:57:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment