build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38500 )
Change subject: Common code romstage ......................................................................
Patch Set 1:
(50 comments)
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... File src/soc/intel/apollolake/romstage.c:
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 270: /* Only for GLK */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 271: FSP_M_CONFIG *m_cfg = &mupd->FspmConfig; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 271: FSP_M_CONFIG *m_cfg = &mupd->FspmConfig; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 271: FSP_M_CONFIG *m_cfg = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 273: m_cfg->PrmrrSize = get_prmrr_size(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 273: m_cfg->PrmrrSize = get_prmrr_size(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 275: /* code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 276: * CpuMemoryTest in FSP tests 0 to 1M of the RAM after MRC init. code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 277: * With PAGING_IN_CACHE_AS_RAM enabled for GLK, there was no page code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 278: * table entry for this range which caused a page fault. Since this code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 279: * test is anyway not exhaustive, skipping the memory test in FSP. code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 280: */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 281: m_cfg->SkipMemoryTestUpd = 1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 281: m_cfg->SkipMemoryTestUpd = 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 283: /* code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 284: * PCIe power sequence can be done from within FSP when provided code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 285: * with the GPIOs used for PERST to FSP. Since this is done in code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 286: * coreboot, skipping the PCIe power sequence done by FSP. code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 287: */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 288: m_cfg->SkipPciePowerSequence = 1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 288: m_cfg->SkipPciePowerSequence = 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 340: struct romstage_ops *rs_ops = soc_get_ops(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 340: struct romstage_ops *rs_ops = soc_get_ops(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 342: if (punit_init()) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 342: if (punit_init()) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 343: set_max_freq(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 343: set_max_freq(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 344: else code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 344: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 345: printk(BIOS_DEBUG, "Punit failed to initialize properly\n"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 345: printk(BIOS_DEBUG, "Punit failed to initialize properly\n"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 347: /* Stash variable MRC data and let cache system update it later */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 348: new_var_data = fsp_find_extension_hob_by_guid(hob_variable_guid, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 348: new_var_data = fsp_find_extension_hob_by_guid(hob_variable_guid, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 349: &var_size); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 349: &var_size); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 350: if (new_var_data) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 350: if (new_var_data) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 351: mrc_cache_stash_data(MRC_VARIABLE_DATA, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 351: mrc_cache_stash_data(MRC_VARIABLE_DATA, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 352: fsp_version, new_var_data, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 352: fsp_version, new_var_data, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 353: var_size); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 353: var_size); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 354: else code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 354: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 355: printk(BIOS_ERR, "Failed to determine variable data\n"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 355: printk(BIOS_ERR, "Failed to determine variable data\n"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 357: mainboard_save_dimm_info(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38500/1/src/soc/intel/apollolake/ro... PS1, Line 357: mainboard_save_dimm_info(); please, no spaces at the start of a line