Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32701 )
Change subject: arch/cpu: Rename mp_get_apic_id() function ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/32701/1/src/arch/x86/cpu.c File src/arch/x86/cpu.c:
https://review.coreboot.org/#/c/32701/1/src/arch/x86/cpu.c@237 PS1, Line 237: APIC id This is the default apic id that comes out of reset, correct? No the current one?
https://review.coreboot.org/#/c/32701/1/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:
https://review.coreboot.org/#/c/32701/1/src/cpu/x86/mp_init.c@200 PS1, Line 200: info->cpu = dev_find_path(NULL, DEVICE_PATH_CPU_CLUSTER);
i can verify and get back
I would definitely prefer to keep the ordering of dev assignment. Can't we just expose a routine that does the dev assignment such that the order is consistent in how it is here?
https://review.coreboot.org/#/c/32701/1/src/cpu/x86/mp_init.c@976 PS1, Line 976: MP_FR_BLOCK_APS(mp_initialize_cpu, mp_initialize_cpu),
No, there is a much older step that we do since Sandy Bridge, IIRC. […]
Ya. I don't think we should have so much churn in this change. We should be able to expose an API to utilize at the key parts such that it's only a few line change.