Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40247 )
Change subject: soc/amd/picasso/i2c: don't initialize I2C4 as master and refactor code ......................................................................
Patch Set 4: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/40247/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40247/4//COMMIT_MSG@9 PS4, Line 9: don't Remove
https://review.coreboot.org/c/coreboot/+/40247/4//COMMIT_MSG@12 PS4, Line 12: Also some Also *do* some
https://review.coreboot.org/c/coreboot/+/40247/4/src/soc/amd/picasso/i2c.c File src/soc/amd/picasso/i2c.c:
https://review.coreboot.org/c/coreboot/+/40247/4/src/soc/amd/picasso/i2c.c@2... PS4, Line 24: [] If the array size was "I2C_MASTER_DEV_COUNT + I2C_SLAVE_DEV_COUNT", would the _Static_assert still be needed? It would definitely fail to build if there are excess elements in the array initializer, but not sure what would happen if there are less.