Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33777 )
Change subject: asus/am1i-a: set VGA_BIOS_ID to 1002,9830 instead of default 1002,9836 ......................................................................
Patch Set 1:
(2 comments)
Have you thought of removing the default ID? As Elyes pointed out, one is already defined on src/northbridge/amd/agesa/family16kb/Kconfig
https://review.coreboot.org/#/c/33777/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33777/1//COMMIT_MSG@7 PS1, Line 7: set VGA_BIOS_ID to 1002,9830 instead of default 1002,9836 No need to mention the IDs here
https://review.coreboot.org/#/c/33777/1/src/mainboard/asus/am1i-a/Kconfig File src/mainboard/asus/am1i-a/Kconfig:
https://review.coreboot.org/#/c/33777/1/src/mainboard/asus/am1i-a/Kconfig@47 PS1, Line 47: default "1002,9830"
I think it is done here src/northbridge/amd/agesa/family16kb/Kconfig
True, there is no need to replace it here.