[coreboot-gerrit] Change in ...coreboot[master]: mb/google/octopus: Create Garg variant

[Kevin Chiu (Code Review)]

Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32835 )

Change subject: mb/google/octopus: Create Garg variant
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/32835/2/src/mainboard/google/octopus/variant... 
File src/mainboard/google/octopus/variants/garg/overridetree.cb:

https://review.coreboot.org/#/c/32835/2/src/mainboard/google/octopus/variant... 
PS2, Line 7: 	register "emmc_tx_cmd_cntl" = "0x505"
> I am not sure if all the EMMC Tuning and I2C tunings have been done. […]

Hi Karthik
we can't access b:120561055 so I suppose emmc tuning should be done already because of this CL (https://review.coreboot.org/c/30176) was merged on Bobba already.

or do you still suggest us to do the emmc tuning again on Garg?
if so, I'll remove these changes of CL:30176 for Garg variant initial.

thank you.