3 Dec
2019
3 Dec
'19
3:27 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37402 )
Change subject: amdblocks/acpimmio: Unify BIOSRAM usage ......................................................................
Patch Set 8: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37402/8/src/soc/amd/common/block/ac... File src/soc/amd/common/block/acpimmio/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37402/8/src/soc/amd/common/block/ac... PS8, Line 8: bootblock-$(CONFIG_SOC_AMD_COMMON_BLOCK_ACPIMMIO) += biosram.c nit: isn't there an `all-` target that could be used instead?
--
To view, visit https://review.coreboot.org/c/coreboot/+/37402
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69a03e4f01d7fb2ffc9f8b5af73d7e4e7ec027da
Gerrit-Change-Number: 37402
Gerrit-PatchSet: 8
Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 03 Dec 2019 15:27:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment