You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31516 )
Change subject: google/kukui: boot up sspm ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/mainboard... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/mainboard... PS1, Line 44: unsigned char buf[BUF_SIZE];
If move to sspm_boot, it will cause build error. […]
Actually the main reason I don't want this array be put here is that: This array is not 'static' (able to be linked with other files) and with a really common name. So if we do want to compress it, I think you can also move it into sspm_boot() and make it static.
https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/mainboard... PS1, Line 48: "sspm"
Could I use sspm. […]
The point is to declare a 'const char*' / macro for the filename.
https://review.coreboot.org/#/c/31516/1/src/soc/mediatek/mt8183/Makefile.inc File src/soc/mediatek/mt8183/Makefile.inc:
https://review.coreboot.org/#/c/31516/1/src/soc/mediatek/mt8183/Makefile.inc... PS1, Line 52: ramstage-y += sspm.c
Why? I think it is in-order in line 52 ?
I think we sort these lines by their basename.