Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31340 )
Change subject: cpu/intel/common: Extend FSB detection to cover TSC
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/31340/11/src/cpu/intel/common/fsb.c
File src/cpu/intel/common/fsb.c:
https://review.coreboot.org/c/coreboot/+/31340/11/src/cpu/intel/common/fsb.c...
PS11, Line 50: *ratio = rdmsr(MSR_EBC_FREQUENCY_ID).lo >> 24;
This rdmsr resets my getac p470 (family 06, model 0f, stepping 06), despite the claim of table 2-48 in docid #335592 that it should return information on scalable bus speed configuration.
Replacing it with *ratio = 1; fixes it for me. Even _adding_ that line after this (ie. the MSR value is disregarded), but keeping the rdmsr in returns to the reset loop.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31340
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib7f1815b3fac7a610f7203720d526eac152a1648
Gerrit-Change-Number: 31340
Gerrit-PatchSet: 11
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hannah.williams@dell.com
Gerrit-Comment-Date: Mon, 23 Sep 2019 18:32:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment