8 Jan
2020
8 Jan
'20
8:24 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38230 )
Change subject: sb/intel/common: Add smbus_set_slave_addr() ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38230/2/src/southbridge/intel/commo... File src/southbridge/intel/common/smbus.h:
https://review.coreboot.org/c/coreboot/+/38230/2/src/southbridge/intel/commo... PS2, Line 35: SMBTRNSADD
It's not obvious at the first sight that this is 0x9
Meh, not a big deal
--
To view, visit https://review.coreboot.org/c/coreboot/+/38230
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7dddb61fab00e0f4f67d4eebee0cfe8dcd99f4ab
Gerrit-Change-Number: 38230
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian david.guckian@intel.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 08 Jan 2020 20:24:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment