Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46054 )
Change subject: mb/intel/adlrvp: Add initial ADL-P mainboard code ......................................................................
Patch Set 7: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/46054/7/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/46054/7/src/mainboard/intel/adlrvp/... PS7, Line 14: GENERATE_SMBIOS_TABLES This should default to yes already, no need to select it
https://review.coreboot.org/c/coreboot/+/46054/3/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/board_info.txt:
https://review.coreboot.org/c/coreboot/+/46054/3/src/mainboard/intel/adlrvp/... PS3, Line 6: y
Nice, but I see that cros-flashrom treats everything starting from Sunrise Point the same.
Ideally flashrom don't expect to see any change as we are in SPI HW-seq mode since SPT PCH where SPI access method for basic operation remain as is.
Right, flashrom uses hwseq mode from SPT onwards, but it reads the IFD contents from the flash chip to know which regions it has. This is useful to only reflash the BIOS region, for instance 😊
There's differences in descriptor contents starting from Cannon Point (300-series PCH), and upstream flashrom handles these chipsets slightly differently to report the correct information. flashrom can use the descriptor contents as a layout file, but needs to be able to parse it correctly.
For Descriptor related changes we have IFD and https://review.coreboot.org/q/topic:%22IFDTOOL%22+(status:open%20OR%20status...) lately fixed.
Alright, so 500-series and 600-series PCH IFD layout should be pretty much the same. Thanks for confirming.
Unfortunately I don't have any SPI Programming Guide for ADL. I see that TGL-LP has the FLMAP3 register, which contains the descriptor Major and Minor revision IDs.
Oh, wonderful! I didn't know about this change. Thanks!
If TGL-LP and ADL have the same descriptor revision IDs, then I imagine the rest of fields would be the same, which would be good enough to add descriptor support to upstream flashrom.
I have added those now as part of IFD latest, if you have TGL coreboot or downloaded from CPFE, you could give a try with latest IFD tool
Alright, will do. Thank you!