Attention is currently required from: Dinesh Gehlot, Kapil Porwal.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74005 )
Change subject: soc/intel/cmn: Implement HECI commands to get version details of ISHC ......................................................................
Patch Set 12:
(6 comments)
File src/soc/intel/common/block/cse/cse_lite.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173168): https://review.coreboot.org/c/coreboot/+/74005/comment/a77f60a1_00881d1d PS12, Line 205: static bool get_partition_info(enum fpt_partition_id id, struct fw_version_resp* resp) "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173168): https://review.coreboot.org/c/coreboot/+/74005/comment/e144b62c_39fe262f PS12, Line 237: if(get_partition_info(FPT_PARTITION_NAME_ISHC,&resp)) { space required after that ',' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173168): https://review.coreboot.org/c/coreboot/+/74005/comment/02520613_a7b6b8ac PS12, Line 237: if(get_partition_info(FPT_PARTITION_NAME_ISHC,&resp)) { space required before that '&' (ctx:OxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173168): https://review.coreboot.org/c/coreboot/+/74005/comment/e4c83671_482c3037 PS12, Line 237: if(get_partition_info(FPT_PARTITION_NAME_ISHC,&resp)) { space required before the open parenthesis '('
File src/soc/intel/common/block/include/intelblocks/cse.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173168): https://review.coreboot.org/c/coreboot/+/74005/comment/d2c24d1c_bc7d3599 PS12, Line 145: struct cse_fw_ish_version_info{ missing space after struct definition
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173168): https://review.coreboot.org/c/coreboot/+/74005/comment/78a6a06f_64ddd487 PS12, Line 152: struct cse_fw_partition_info{ missing space after struct definition