Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85711?usp=email )
Change subject: mb/starlabs/starlite_adl: Put options in CFR cbtable
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/starlabs/starlite_adl/cfr.c:
https://review.coreboot.org/c/coreboot/+/85711/comment/d5b2fc6e_62ca0612?usp... :
PS7, Line 320: void lb_board(struct lb_header *header)
: {
: char *current = (char *)lb_new_record(header);
: struct lb_cfr *cfr_root = (struct lb_cfr *)current;
:
: cfr_write_setup_menu(cfr_root, sm_root);
: }
should be: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85711?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If92f61dece7e67bfd2e29927198c9ebb81c4d363
Gerrit-Change-Number: 85711
Gerrit-PatchSet: 9
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Comment-Date: Sat, 11 Jan 2025 22:45:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com