Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37010 )
Change subject: sb/intel/common/smihandler: Use a common IO TRAP handler
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37010/5/src/southbridge/intel/commo...
File src/southbridge/intel/common/smihandler.c:
https://review.coreboot.org/c/coreboot/+/37010/5/src/southbridge/intel/commo...
PS5, Line 472: mask |= (0xff << ((i - 16) << 2));
(i - 16) * 8?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37010
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85ff060012f68087edce6946b05181ee6b84a135
Gerrit-Change-Number: 37010
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 24 Dec 2019 19:04:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment