[coreboot-gerrit] [M] Change in coreboot[master]: acpi: Add a debug option to print out tables in ACPICA compatible hex

[Nico Huber (Code Review)]

Attention is currently required from: Arthur Heymans, Benjamin Doron, Kyösti Mälkki, Lance Zhao, Lean Sheng Tan, Tim Wawrzynczak.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75677?usp=email )

Change subject: acpi: Add a debug option to print out tables in ACPICA compatible hex
......................................................................

Patch Set 3: Code-Review+1

(2 comments)

File src/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/75677/comment/72f8e7d4_7de4a959 :
PS2, Line 1854: printk(BIOS_SPEW, "    %04lX:", i);
> There is build error here from Jenkins: […]

Done

File src/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/75677/comment/8583bd03_09cdbc76 :
PS3, Line 1874: {}
Maybe make this `[sizeof(header->signature) + 1] = { 0, }` to make it clear
that it's about 0 termination.
(random alternative: `%.4s` should do as well, w/o termination)

Also, a blank line after the declarations would make it look less bulky.