Attention is currently required from: Furquan Shaikh, Henry Sun, Weimin Wu.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51430 )
Change subject: mb/google/dedede/var/sasukette: Add ALC1015 AMP (Auto Mode) driver
......................................................................
Patch Set 2: -Code-Review
(1 comment)
File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/51430/comment/b54d2fae_ffca9807
PS2, Line 33: select DRIVERS_GENERIC
Furquan/Patick, I believe the compiler is smart enough to keep the driver only in the variants where it is used.
Can you please confirm if my understanding is correct?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51430
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa5650e120362e81fa36530f6a207c9c07e1139a
Gerrit-Change-Number: 51430
Gerrit-PatchSet: 2
Gerrit-Owner: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jessie Xu
xuyanan@huaqin.corp-partner.google.com
Gerrit-CC: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-CC: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Fri, 12 Mar 2021 21:19:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment