Attention is currently required from: Tarun Tuli, Jamie Ryu, Wonkyu Kim, Ravishankar Sarawadi, Kapil Porwal, Angel Pons, Nick Vaccaro, Tim Wawrzynczak, Raj Astekar.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66102 )
Change subject: mb/intel/mtlrvp: Add MTL-P RVP board ids
......................................................................
Patch Set 5:
(4 comments)
File src/mainboard/intel/mtlrvp/board_id.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164519):
https://review.coreboot.org/c/coreboot/+/66102/comment/04efd8d6_f063f536
PS5, Line 28: printk(BIOS_INFO, "id from Chrome EC 0x%x\n",(unsigned int)id);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164519):
https://review.coreboot.org/c/coreboot/+/66102/comment/b19a11cf_e4e47e31
PS5, Line 36: if ((id == 0)||(id == BOARD_ID_UNKNOWN)) {
spaces required around that '||' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164519):
https://review.coreboot.org/c/coreboot/+/66102/comment/93c8a691_c4186c30
PS5, Line 37: for(int i = 0; i < 100; i++)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164519):
https://review.coreboot.org/c/coreboot/+/66102/comment/fbc77878_f9c9cf26
PS5, Line 38: printk(BIOS_ERR, "Invalid board_id(0x%d). Please check"
Prefixing 0x with decimal output is defective
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66102
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90b0543d5db208f696d2c2c2dc3d2581514a845b
Gerrit-Change-Number: 66102
Gerrit-PatchSet: 5
Gerrit-Owner: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Raj Astekar
raj.astekar@intel.com
Gerrit-Comment-Date: Fri, 25 Nov 2022 10:28:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment