Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Documentation/mb/ocp/tiogapass: Add documentation ......................................................................
Patch Set 1:
(17 comments)
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 3: OCP (Open Compute Project) : TiogaPass server Add a link for OCP Web site or the server platform?
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 9: collatoral Learnt a new meaning: https://www.merriam-webster.com/dictionary/collateral. Thanks. ;-)
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 11: collaboral collatoral?
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 21: ## Required blobs Add a space above?
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 26: Microcode - Use one space instead of the tab?
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 26: 3rdparty/intel-microcode/intel-ucode/06-55-04 Mark up as code with `…`?
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 41: fw-util mb --force --update <path to coreboot image> Please indent with four spaces to mark it up as a code block.
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 44: power-util mb off : power-util mb on Ditto.
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 48: sol-util mb Ditto.
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 52: target OS and Linuxboot kernel paramter. Please list it here. `processor.max_cstate`?
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 56: - There is boot stability issue. Please give more detail.
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 63: - None ???
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 65: ## Working Please list first, what payload (with version) and Linux version you used for testing.
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 66: - Most SMBIOS types. Please remove dot/period at the end.
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 68: -- BMC readiness check Does that convert correctly in Markdown? Indent with four spaces and use one -?
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 71: -- POST complete pin acknowledgement. No dot/period at the end (also below).
https://review.coreboot.org/c/coreboot/+/40925/1/Documentation/mainboard/ocp... PS1, Line 81: SkyLake Skylake