6 Nov
2019
6 Nov
'19
1:15 p.m.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36642 )
Change subject: drivers/i2c/ptn3460: Provide chip driver for PTN3460 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36642/1/src/drivers/i2c/ptn3460/chi... File src/drivers/i2c/ptn3460/chip.h:
https://review.coreboot.org/c/coreboot/+/36642/1/src/drivers/i2c/ptn3460/chi... PS1, Line 1: struct
Do we need a header in this file?
I guess not since here the structure is defined (which is empty as the parameters are handled differently). This definition is mandatory to make the chip construct work.
--
To view, visit https://review.coreboot.org/c/coreboot/+/36642
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4c8176cd16836fa5b8fd2f72faf7a55723b82f6
Gerrit-Change-Number: 36642
Gerrit-PatchSet: 1
Gerrit-Owner: uwe taz
Gerrit-Reviewer: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: uwe taz
Gerrit-Comment-Date: Wed, 06 Nov 2019 12:15:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-MessageType: comment