Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34332 )
Change subject: mediatek/mt8183: Support more DRAM frequency bootup ......................................................................
Patch Set 21:
(7 comments)
https://review.coreboot.org/c/coreboot/+/34332/15/src/soc/mediatek/mt8183/dr... File src/soc/mediatek/mt8183/dramc_init_setting.c:
https://review.coreboot.org/c/coreboot/+/34332/15/src/soc/mediatek/mt8183/dr... PS15, Line 639: TIMEOUT_CNT
TIMEOUT_US = 100
Done
https://review.coreboot.org/c/coreboot/+/34332/15/src/soc/mediatek/mt8183/dr... PS15, Line 658: while (!wait_us(1, read32(&ch[chn].nao.spcmdresp) & (0x1 << 4)) && (time_cnt > 0)) : time_cnt--; : : if (time_cnt == 0) { : dramc_dbg("ZQCAL Start fail (time out)\n"); : return 1; : }
if (!wait_us(TIMEOUT_US, read32(&ch[chn].nao.spcmdresp) & 0x1 << 4) { […]
Done
https://review.coreboot.org/c/coreboot/+/34332/15/src/soc/mediatek/mt8183/dr... PS15, Line 671: : while (!wait_us(1, read32(&ch[chn].nao.spcmdresp) & (0x1 << 6)) && (time_cnt > 0)) : time_cnt--; : : if (time_cnt == 0) { : dramc_dbg("ZQCAL Latch fail (time out)\n"); : return 1; : }
if (!wait_us(TIMEOUT_US, read32(&ch[chn].nao.spcmdresp) & 0x1 << 6)) { […]
Done
https://review.coreboot.org/c/coreboot/+/34332/13/src/soc/mediatek/mt8183/dr... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/34332/13/src/soc/mediatek/mt8183/dr... PS13, Line 870: coarse_start = 22;
Consider […]
Done
https://review.coreboot.org/c/coreboot/+/34332/13/src/soc/mediatek/mt8183/dr... PS13, Line 1053:
Extra space
Done
https://review.coreboot.org/c/coreboot/+/34332/13/src/soc/mediatek/mt8183/dr... PS13, Line 1098: adjust_cneter
adjust_center
Done
https://review.coreboot.org/c/coreboot/+/34332/15/src/soc/mediatek/mt8183/dr... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/34332/15/src/soc/mediatek/mt8183/dr... PS15, Line 701: dqs, dly_coarse_large_cnt[dqs], dly_coarse_0p5t_cnt[dqs], dly_fine_tune_cnt[dqs]);
line over 96 characters
Done