[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Dump ME f/w version and status information.

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32527 )

Change subject: soc/intel/cannonlake: Dump ME f/w version and status information.
......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/#/c/32527/8/src/soc/intel/cannonlake/include/soc... 
File src/soc/intel/cannonlake/include/soc/me.h:

https://review.coreboot.org/#/c/32527/8/src/soc/intel/cannonlake/include/soc... 
PS8, Line 4: Inc.
> LLC

Done

https://review.coreboot.org/#/c/32527/8/src/soc/intel/cannonlake/me.c 
File src/soc/intel/cannonlake/me.c:

https://review.coreboot.org/#/c/32527/8/src/soc/intel/cannonlake/me.c@235 
PS8, Line 235: print_me_version
> And the reason why this cannot be called from dump_me_status() is probably because its too late and  […]

I tried calling this from dump_me_status(), and the HECI command times out, so I followed the SKL/KBL model and that worked.  I don't see any notes in the CSME document (either version) about when the command can and cannot be sent, but maybe I missed it.  Added a comment explaining this.