[coreboot-gerrit] [L] Change in coreboot[main]: soc/intel/common/systemagent_server: Add server platform system agent

[Name of user not set (Code Review)]

Attention is currently required from: Angel Pons, Arthur Heymans, Felix Held, Felix Singer, Jérémy Compostella, Paul Menzel, Shuo Liu.

[e-mail] has posted comments on this change by [e-mail]. ( https://review.coreboot.org/c/coreboot/+/83318?usp=email )

Change subject: soc/intel/common/systemagent_server: Add server platform system agent
......................................................................

Patch Set 25:

(4 comments)

File src/soc/intel/common/block/systemagent-server/memmap.c:

https://review.coreboot.org/c/coreboot/+/83318/comment/0614ac0b_b29808de?usp... :
PS24, Line 23: 	 */
> if you only support FSP_TEMP_RAM_EXIT now, can you assert instead?

Added a `die()` here.

File src/soc/intel/common/block/systemagent-server/systemagent.c:

https://review.coreboot.org/c/coreboot/+/83318/comment/9063d06c_7a4b8212?usp... :
PS24, Line 76: 				continue;
> if (mmio_descriptors[i].get_resource) { […]

If `size` and `base` are not provided, get them from `get_resource()` function.

https://review.coreboot.org/c/coreboot/+/83318/comment/287994b1_fb38b875?usp... :
PS24, Line 184: 	sa_server_soc_add_configurable_mmio_resources(dev, &index);
> Maybe to merge these 2 MMIO config into 1 and do it for pch domain only.

Done

https://review.coreboot.org/c/coreboot/+/83318/comment/69ee4dab_36167ed5?usp... :
PS24, Line 191: 	.init             = sa_server_soc_systemagent_init,
> For the null implementation, can we skip the assignment directly?

Done