24 May
2024
24 May
'24
12:46 p.m.
Attention is currently required from: Cliff Huang, Jérémy Compostella, Lance Zhao, Tim Wawrzynczak.
Felix Held has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/82642?usp=email )
Change subject: acpi: drop sort-of duplicate ACPI_HAVE_PCAT_8259 option ......................................................................
Patch Set 1:
(1 comment)
File src/acpi/acpi_apic.c:
https://review.coreboot.org/c/coreboot/+/82642/comment/92e46a5a_fcaff2ed?usp... : PS1, Line 130: ACPI_HAVE_PCAT_8259
the spec says this in the explanation of the SCI_INT FADT field: "System vector the SCI interrupt is […]
pushed a follow-up adding comments with a bit of documentation
--
To view, visit https://review.coreboot.org/c/coreboot/+/82642?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I246ecfda5bb156d151512e5dbf432a113fad51a2
Gerrit-Change-Number: 82642
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Cliff Huang cliff.huang@intel.com
Gerrit-Reviewer: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Lance Zhao lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang cliff.huang@intel.com
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Comment-Date: Fri, 24 May 2024 15:46:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Comment-In-Reply-To: Elyes Haouas ehaouas@noos.fr