[coreboot-gerrit] Change in ...coreboot[master]: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )

Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/31450/3/src/mainboard/lenovo/g505s/OemCustom... 
File src/mainboard/lenovo/g505s/OemCustomize.c:

https://review.coreboot.org/#/c/31450/3/src/mainboard/lenovo/g505s/OemCustom... 
PS3, Line 212: 	if (IS_ENABLED(CONFIG_MULTIPLE_VGA_ADAPTERS)) {
> Can't you autodetect this at runtime ? […]

you can also enable and configure the bus to see if you can find a VGA behind it. IMO you should just unconditionally set 0xd0, unless you really care about 32bit OS, without PAE.