Attention is currently required from: Fabian Groffen, Keith Hui, Keith Hui.
Felix Held has posted comments on this change by Fabian Groffen. ( https://review.coreboot.org/c/coreboot/+/75145?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/asus/p8z77-m: Drop GPIO by I/O
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
I finally tested on hardware. CB:81926 did fix the underlying issue. […]
so this patch isn't necessary and shouldn't be submitted, right?
on the block not working: haven't checked, but that might be due to a missing lpc decode range. haven't decode the magic value of gen1_dec; if that one is another io window, there are more of those lpc decode range registers
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75145?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I22654f3c77082bf163ab7000ec467ab7085a0534
Gerrit-Change-Number: 75145
Gerrit-PatchSet: 4
Gerrit-Owner: Fabian Groffen
grobian@gentoo.org
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Keith Hui
buurin@gmail.com
Gerrit-Attention: Keith Hui
buurin@gmail.com
Gerrit-Attention: Fabian Groffen
grobian@gentoo.org
Gerrit-Comment-Date: Mon, 27 May 2024 12:48:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Keith Hui
buurin@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de