Attention is currently required from: Andrey Petrov, Julius Werner, Ronak Kanabar, Shelley Chen.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79775?usp=email )
Change subject: Choose Correct FW splash screen at runtime ......................................................................
Patch Set 7:
(1 comment)
File src/lib/Kconfig:
https://review.coreboot.org/c/coreboot/+/79775/comment/45b4926a_9a5b84e5 : PS6, Line 153: HAVE_CUSTOM_BMP_LOGO
The HAVE_CUSTOM_BMP_LOGO config should be automatically selected by the CHROMEOS_FW_SPLASH_SCREEN Kconfig, so the user doesn't need to know about this flag.
This is good idea. I like this
My understanding is all modern chromebooks just need:
CONFIG_CHROMEOS_FW_SPLASH_SCREEN=y CONFIG_CB_LOGO_PATH=<cb_logo_path> CONFIG_CB_PLUS_LOGO_PATH=<cbplus_logo_path>
old legacy chromebooks would still use the old construct: CONFIG_BMP_LOGO=y CONFIG_FSP2_0_LOGO_FILE_NAME=<logo_path>
Yes, I agree with above assumptions. Even the config CL i have submitted for Rex variants does what you have captured above.
I don't expect to see legacy devices for MTL. may be few Brya early 2023 launches are the one along with few Nissa device (may be).
By legacy device, Subrata, you mean devices that don't have the factory config set correctly, right?
correct. Those devices are relying on RW VPD for factory flow.