Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32526 )
Change subject: Makefile.inc: Update fsp submodule for all FSP platforms
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32526/1/Makefile.inc
File Makefile.inc:
https://review.coreboot.org/#/c/32526/1/Makefile.inc@199
PS1, Line 199: forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/fsp))
Alternatively, how about condensing it to this: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32526
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If07d55828a1863623e04a4ecdd1514c3cb6d9c11
Gerrit-Change-Number: 32526
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 03 May 2019 15:53:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment