Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45082 )
Change subject: mb/google/zork:Set HotplugEnhanced to NVME SSD ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45082/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/fsps_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/45082/1/src/mainboard/google/zork/v... PS1, Line 30: .link_hotplug = 3, // HotplugEnhanced Can we please introduce some macros that provide semantic meaning instead of open coded values?
https://review.coreboot.org/c/coreboot/+/45082/1/src/mainboard/google/zork/v... PS1, Line 76: .link_hotplug = 3, // HotplugEnhanced Why would this only need to be applied to nvme root port? Why wouldn't this be needed for all root ports?