Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31101 )
Change subject: src/soc/intel/cannonlake: Add _DSM methods for LPIT table ......................................................................
Patch Set 15:
(5 comments)
Patch Set 11:
(4 comments)
https://review.coreboot.org/#/c/31101/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31101/11//COMMIT_MSG@10 PS11, Line 10: get
gets?
Done
https://review.coreboot.org/#/c/31101/11//COMMIT_MSG@17 PS11, Line 17: does
do
Done
https://review.coreboot.org/#/c/31101/11//COMMIT_MSG@17 PS11, Line 17: throws
throw
Done
https://review.coreboot.org/#/c/31101/5/src/soc/intel/cannonlake/acpi/lpit.a... File src/soc/intel/cannonlake/acpi/lpit.asl:
https://review.coreboot.org/#/c/31101/5/src/soc/intel/cannonlake/acpi/lpit.a... PS5, Line 26: LEqual(Arg0, ^UUID)
Done
I was testing with this new syntax but it didnt worked with this. No compilation error but seems like its not able to parse this new syntax. Need to debug if there is some version mismatch issue.
https://review.coreboot.org/#/c/31101/11/src/soc/intel/cannonlake/acpi/lpit.... File src/soc/intel/cannonlake/acpi/lpit.asl:
https://review.coreboot.org/#/c/31101/11/src/soc/intel/cannonlake/acpi/lpit.... PS11, Line 75: //device (LPID)
Space after //.
Done