Attention is currently required from: Derek Huang, Karthik Ramasubramanian, Paul Menzel, Shou-Chieh Hsu.
Robert Chen has posted comments on this change by Robert Chen. ( https://review.coreboot.org/c/coreboot/+/84953?usp=email )
Change subject: mb/google/dedede/var/drawcia: Correct board version in variant_devicetree_update ......................................................................
Patch Set 11:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84953/comment/315b349f_698a94c6?usp... : PS8, Line 7: Fix devicetree_update
Something more specific would be nice.
Done
File src/mainboard/google/dedede/variants/drawcia/ramstage.c:
https://review.coreboot.org/c/coreboot/+/84953/comment/e0ef6559_ef123dcc?usp... : PS8, Line 14:
Unrelated.
Done
https://review.coreboot.org/c/coreboot/+/84953/comment/125dd646_8fca8d10?usp... : PS8, Line 36: if (board_version > 0xb) : ext_vr_update();
Before it was run for `board_version < 9`. […]
Used to be `board_version < 9` not run, Change to
https://review.coreboot.org/c/coreboot/+/84953/comment/070db2a5_56def160?usp... : PS8, Line 38: /* Remove power IC after board version 0xc */
What about 0xf? Should it be mentioned in the comment?
Refering to Dedede-Drawcia DesignConfigID + FW_Config Sheet. Drawper actully board version 0xa, 0xb and 0xf.
https://review.coreboot.org/c/coreboot/+/84953/comment/232cd5d3_cf0dc594?usp... : PS8, Line 38: /* Remove power IC after board version 0xc */ : if (board_version != 0xa && : board_version != 0xb && : board_version != 0xf) : update_lte_device_drawcia(); : /* board version 0xa, 0xb , 0xf is for drawper unit */
This is not mentioned in the commit message. […]
Done