[coreboot-gerrit] Change in coreboot[master]: FSP 2.0: Add fsp_relax_security

[Julien Viard de Galbert (Code Review)]

Julien Viard de Galbert has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25437 )

Change subject: FSP 2.0: Add fsp_relax_security
......................................................................

Patch Set 20:

(2 comments)

Thanks for the hint, I'll use CHIPSET_LOCKDOWN_{FSP,COREBOOT} on the next update of this patch.

https://review.coreboot.org/c/coreboot/+/25437/18/src/drivers/intel/fsp2_0/n... 
File src/drivers/intel/fsp2_0/notify.c:

https://review.coreboot.org/c/coreboot/+/25437/18/src/drivers/intel/fsp2_0/n... 
PS18, Line 70: __attribute__((weak)) bool fsp_relax_security(void)
> instead of *another* callback, why not have a Kconfig?

Well the purpose was to set it at runtime, not compile time ;)

https://review.coreboot.org/c/coreboot/+/25437/18/src/drivers/intel/fsp2_0/n... 
PS18, Line 70: fsp_relax_security
> Maybe rename this to sound less like an action? E. g. […]

Right I missed the introduction of CHIPSET_LOCKDOWN_COREBOOT, I can certainly rewrite it using that.

Will do.