Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34838 )
Change subject: mb/up/squared: Do RAM config based on SKU ID
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34838/2/src/mainboard/up/squared/ro...
File src/mainboard/up/squared/romstage.c:
https://review.coreboot.org/c/coreboot/+/34838/2/src/mainboard/up/squared/ro...
PS2, Line 31: cons
Do you know what each bit combination corresponds to? Something like this table I made up: […]
Done
https://review.coreboot.org/c/coreboot/+/34838/2/src/mainboard/up/squared/ro...
PS2, Line 149: return memory_skuid;
I think it is better to do this in mainboard_memory_init_params(), since the evaluation is there.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34838
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic121652213d5b1f65cff2f3096e919a3cf88db72
Gerrit-Change-Number: 34838
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 10 Sep 2019 16:15:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment