Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46304 )
Change subject: include/device/device.h: Move resource debug macros ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46304/4/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/46304/4/src/Kconfig@918 PS4, Line 918: # Only visible if DEBUG_SPEW (8) is set. It does additional printk(BIOS_DEBUG, ...) calls. : config HAVE_DEBUG_RESOURCES : def_bool n Any reason to have this platform specific flag?
https://review.coreboot.org/c/coreboot/+/46304/4/src/Kconfig@922 PS4, Line 922: config DEBUG_RESOURCES At the moment this is used to print not even 10 more lines in the whole log? Is just using BIOS_SPEW with no additional Kconfig flag not enough?
https://review.coreboot.org/c/coreboot/+/46304/4/src/Kconfig@927 PS4, Line 927: This option enables additional PCI memory and IO debug messages. : : Note: This option will increase the size of the coreboot image. : : If unsure, say N Remove the empty lines in between