Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31616 )
Change subject: superio/ite/common: add option for enabling 5 FANs
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31616/3/src/superio/ite/common/env_ctrl.h
File src/superio/ite/common/env_ctrl.h:
https://review.coreboot.org/#/c/31616/3/src/superio/ite/common/env_ctrl.h@66
PS3, Line 66: )
There is still a forest of parentheses that only distracts […]
Another idea that might keep it more readable and could
be easier optimized by the compiler:
#define ITE_EC_FAN_TAC_LIMIT(x) \
((x) > 3 && IS_ENABLED(CONFIG_SUPERIO_ITE_ENV_CTRL_5FANS) \
? 0x84 + ((x)-4) * 2 \
: 0x10 + ((x)-1))
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31616
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd60a16b6b5583a3b981bdc220aac472c2a8f40f
Gerrit-Change-Number: 31616
Gerrit-PatchSet: 3
Gerrit-Owner: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Fri, 01 Mar 2019 12:25:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
