Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47442 )
Change subject: vendorcode/google/chromesos/sar: Reduce severity of debug message ......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/c/coreboot/+/47442/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47442/2//COMMIT_MSG@7 PS2, Line 7: chromesos chromeos
https://review.coreboot.org/c/coreboot/+/47442/2//COMMIT_MSG@7 PS2, Line 7: vendorcode/google/chromesos/sar: Reduce severity of debug message Maybe:
vc/google/chromeos/sar: Make SAR not found log a debug message
https://review.coreboot.org/c/coreboot/+/47442/2//COMMIT_MSG@10 PS2, Line 10: debug message message
https://review.coreboot.org/c/coreboot/+/47442/2//COMMIT_MSG@13 PS2, Line 13: Lowering severity to BIOS_DEBUG to avoid this issue Please add a dot/period at the end.
https://review.coreboot.org/c/coreboot/+/47442/2//COMMIT_MSG@13 PS2, Line 13: to avoid avoids
https://review.coreboot.org/c/coreboot/+/47442/2//COMMIT_MSG@13 PS2, Line 13: BIOS_DEBUG Why not `BIOS_INFO`?
https://review.coreboot.org/c/coreboot/+/47442/2/src/vendorcode/google/chrom... File src/vendorcode/google/chromeos/sar.c:
https://review.coreboot.org/c/coreboot/+/47442/2/src/vendorcode/google/chrom... PS2, Line 71: /* Try to read the SAR limit entry from VPD */ It’d be great, if you could sent a follow-up updating this comment too.