[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/icelake: Add option to enable display over PCI external GFX

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33739 )

Change subject: soc/intel/icelake: Add option to enable display over PCI external GFX
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/33739/7/src/soc/intel/icelake/fsp_params.c 
File src/soc/intel/icelake/fsp_params.c:

https://review.coreboot.org/#/c/33739/7/src/soc/intel/icelake/fsp_params.c@9... 
PS7, Line 92: 			params->Enable8254ClockGating = 0;
In change https://review.coreboot.org/c/coreboot/+/33512 it was fixed on cannonlake. Making use of CONFIG_USE_LEGACY_8254_TIMER seems fine, as it can be selected by PAYLOAD_SEABIOS or VGA_ROM_RUN.
Also there's no need to have a dependency to disabled IGD. One might run dGPU oprom even with IGD enabled.