Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32858 )
Change subject: console: Move poor-man's atoi() into string.h ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/32858/4/src/include/string.h File src/include/string.h:
https://review.coreboot.org/#/c/32858/4/src/include/string.h@182 PS4, Line 182: /* Parses an unsigned integer and moves the input pointer forward to the first : character that's not a valid digit. s and *s must not be NULL. Result : undefined if it overruns the return type size. */
I though for headers the elaborate multi-line comment style (and not concise) should be used.
I am not aware of any such rule, AFAIR it's just about length and whether it's a single comment that just happened to go over the line or an elaborate multi-paragraph document. But I can change it here if you prefer.
https://review.coreboot.org/#/c/32858/3/src/include/string.h File src/include/string.h:
https://review.coreboot.org/#/c/32858/3/src/include/string.h@184 PS3, Line 184: static inline
It's clear that LTO doesn't have a huge impact on boot time or code size. […]
What I was trying to say is that I don't think that an external function linked with LTO can always be optimized as much as an inline. AFAIK current LTO implementations are still way too limited for that (especially in cases where large parts of the function essentially constant-fold away into nothing). But I'm not an expert on the topic so I might be wrong.
Regardless, as far as I'm aware coreboot isn't using it atm (maybe someone should look into that?).