David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38546 )
Change subject: cpu/x86: Make MP init timeout configurable
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38546/1/src/cpu/x86/mp_init.c
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/38546/1/src/cpu/x86/mp_init.c@525
PS1, Line 525: const int timeout_us = CONFIG_FLIGHT_PLAN_TIMEOUT_US;
It is oaky for me to simply increase the timeout for all targets, if this is fine for the community. […]
We have num_aps defined below, maybe we can use that as a multiplier? So for example, 100ms per AP with a minimum of 1s:
int num_aps = mp_params->num_cpus - 1;
int timeout_us = min(1000000, 100000 * num_aps);
That removes the need for yet another Kconfig variable and is also consistent with what the comment above suggests about time potentially increasing due to contention of resources such as UART.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38546
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc079fc6aa8641d4ac8d8e726899b6c8d055052e
Gerrit-Change-Number: 38546
Gerrit-PatchSet: 8
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
anpetrov@fb.com
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 Jan 2020 01:57:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment