19 Apr
2019
19 Apr
'19
5:06 a.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32292 )
Change subject: mb/google/hatch: Pull up GPP_C13 ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32292/4/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/32292/4/src/mainboard/google/hatch/variants/... PS4, Line 150: UP_20K Actually can you add the pull-up to override table in hatch and hatch_whl. I don't think any of the other variants will need this.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32292
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc1f89fc25773220db009c6571400b01390dd756
Gerrit-Change-Number: 32292
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Chen philipchen@google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Philip Chen philipchen@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 19 Apr 2019 03:06:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment