Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46510 )
Change subject: mrc_cache: Move mrc_cache_*_hash functions into mrc_cache driver ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46510/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46510/3//COMMIT_MSG@9 PS3, Line 9: This CL would remove these calls from fsp 2.0. Can you please add here that for platforms that select MRC_STASH_TO_CBMEM, updating of TPM space is moved from romstage to ramstage (i.e. instead of updating the TPM space when data is stashed to CBMEM, it now happens when data is being written back to SPI flash).
https://review.coreboot.org/c/coreboot/+/46510/3/src/drivers/mrc_cache/mrc_c... File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/46510/3/src/drivers/mrc_cache/mrc_c... PS3, Line 451: mrc_cache_update_hash Because of this change you will have to add mrc_cache_hash_tpm.c to ramstage as well.