Attention is currently required from: Shelley Chen, Ravi kumar. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61342 )
Change subject: qualcomm/sc7280: Add support for edp and mdp driver ......................................................................
Patch Set 13:
(2 comments)
File src/soc/qualcomm/sc7280/display/edp_ctrl.c:
https://review.coreboot.org/c/coreboot/+/61342/comment/a9b785fe_e951275b PS13, Line 363: GPIO_PULL_DOWN, GPIO_2MA, GPIO_INPUT); Unless you're explicitly trying to set a non-standard drive strength, you're supposed to just use gpio_input_pulldown() for this.
https://review.coreboot.org/c/coreboot/+/61342/comment/71897da9_d31b4861 PS13, Line 360: gpio_output(GPIO(80), 1); : mdelay(20); : gpio_configure(GPIO(60), GPIO_FUNC_GPIO, : GPIO_PULL_DOWN, GPIO_2MA, GPIO_INPUT); : mdelay(10); : gpio_output(GPIO(8), 1); : mdelay(20);
any chance that we can clarify what these GPIOs are? Either #define them or at least add comments t […]
These almost certainly don't belong here anyway (maybe the HPD, if that's the only pin the SoC can possibly use for that functionality, but not the others). We already had display voltage rail control on Trogdor, why don't you just copy the way it was done there? Board-specific GPIO handling belongs in mainboard.c.
(FWIW some old Herobrine schematic I have lists GPIO8 as AP_SAR_SENSOR_SDA, not sure if that's still up to date, but you may want to double-check that number.)