Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34385 )
Change subject: drivers/i2c/dw: Don't try to generate unselected speeds in ACPI table
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34385/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34385/3//COMMIT_MSG@11
PS3, Line 11: This quiets a message which looks like a bug ("dw_i2c: bad counts").
In the Linux kernel?
In this driver; I'll update the msg.
https://review.coreboot.org/c/coreboot/+/34385/3/src/drivers/i2c/designware/...
File src/drivers/i2c/designware/dw_i2c.c:
https://review.coreboot.org/c/coreboot/+/34385/3/src/drivers/i2c/designware/...
PS3, Line 846: speed = (bcfg->speed == 0) ? I2C_SPEED_STANDARD : bcfg->speed;
That is a good point.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34385
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I07207ec95652e8af1a42bfe31214f61a183a134e
Gerrit-Change-Number: 34385
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Jul 2019 14:42:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment