Attention is currently required from: Furquan Shaikh, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52801 )
Change subject: mb/google/guybrush: Fix S0i3/S3 GPIO configuration ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/52801/comment/0afab0c3_725aaabb PS1, Line 20: PAD_SCI
I think we might have to use GPIO-controller wake route for the pen eject if we need to apply deboun […]
Interesting. Thanks for pointing that out. I think we need to set this to PAD_GPI instead and make it so the kernel driver can set the wake bits. https://lore.kernel.org/patchwork/patch/1420135/
On my device I don't have the PEN plugged in. I've seen that sometimes when I touch the board the PEN glitches a bit and latches the wake_status bit. Since the OS doesn't have a driver loaded for this, the IRQ never gets enabled, so the wake_status never gets cleared. This results in not being able to stay in S0i3.